Merge branch 'normal-websockets' into 'master'

Parse non-deflated websockets

See merge request packmate/Packmate!5
This commit is contained in:
Sergey
2020-04-10 15:32:35 +00:00
4 changed files with 21 additions and 24 deletions

View File

@@ -22,6 +22,6 @@ public class CtfService {
private boolean mergeAdjacentPackets; private boolean mergeAdjacentPackets;
private boolean inflateWebSockets; private boolean parseWebSockets;
} }

View File

@@ -52,7 +52,7 @@ public class Packet {
private boolean ungzipped; private boolean ungzipped;
private boolean webSocketInflated; private boolean webSocketParsed;
private byte[] content; private byte[] content;

View File

@@ -36,8 +36,8 @@ public class StreamOptimizer {
unpackGzip(); unpackGzip();
} }
if (service.isInflateWebSockets()) { if (service.isParseWebSockets()) {
inflateWebSocket(); parseWebSockets();
} }
if (service.isUrldecodeHttpRequests()) { if (service.isUrldecodeHttpRequests()) {
@@ -89,7 +89,7 @@ public class StreamOptimizer {
final List<Packet> cut = packets.subList(start, end); final List<Packet> cut = packets.subList(start, end);
final long timestamp = cut.get(0).getTimestamp(); final long timestamp = cut.get(0).getTimestamp();
final boolean ungzipped = cut.stream().anyMatch(Packet::isUngzipped); final boolean ungzipped = cut.stream().anyMatch(Packet::isUngzipped);
final boolean webSocketInflated = cut.stream().anyMatch(Packet::isWebSocketInflated); final boolean webSocketParsed = cut.stream().anyMatch(Packet::isWebSocketParsed);
boolean incoming = cut.get(0).isIncoming(); boolean incoming = cut.get(0).isIncoming();
//noinspection OptionalGetWithoutIsPresent //noinspection OptionalGetWithoutIsPresent
final byte[] content = cut.stream() final byte[] content = cut.stream()
@@ -102,7 +102,7 @@ public class StreamOptimizer {
.incoming(incoming) .incoming(incoming)
.timestamp(timestamp) .timestamp(timestamp)
.ungzipped(ungzipped) .ungzipped(ungzipped)
.webSocketInflated(webSocketInflated) .webSocketParsed(webSocketParsed)
.content(content) .content(content)
.build()); .build());
} }
@@ -223,7 +223,7 @@ public class StreamOptimizer {
.incoming(false) .incoming(false)
.timestamp(cut.get(0).getTimestamp()) .timestamp(cut.get(0).getTimestamp())
.ungzipped(true) .ungzipped(true)
.webSocketInflated(false) .webSocketParsed(false)
.content(newContent) .content(newContent)
.build(); .build();
} catch (ZipException e) { } catch (ZipException e) {
@@ -235,7 +235,7 @@ public class StreamOptimizer {
return null; return null;
} }
private void inflateWebSocket() { private void parseWebSockets() {
if (!packets.get(0).getContentString().contains("HTTP/")) { if (!packets.get(0).getContentString().contains("HTTP/")) {
return; return;
} }

View File

@@ -31,8 +31,6 @@ public class WebSocketsParser {
private static final java.util.regex.Pattern WEBSOCKET_ACCEPT_PATTERN = private static final java.util.regex.Pattern WEBSOCKET_ACCEPT_PATTERN =
java.util.regex.Pattern.compile("Sec-WebSocket-Accept: (.+)\\r\\n"); java.util.regex.Pattern.compile("Sec-WebSocket-Accept: (.+)\\r\\n");
private static final String WEBSOCKET_EXTENSION_HEADER = "Sec-WebSocket-Extension: permessage-deflate";
private static final String WEBSOCKET_EXTENSIONS_HEADER = "Sec-WebSocket-Extensions: permessage-deflate";
private static final String WEBSOCKET_UPGRADE_HEADER = "upgrade: websocket\r\n"; private static final String WEBSOCKET_UPGRADE_HEADER = "upgrade: websocket\r\n";
private static final String WEBSOCKET_CONNECTION_HEADER = "connection: upgrade\r\n"; private static final String WEBSOCKET_CONNECTION_HEADER = "connection: upgrade\r\n";
@@ -103,7 +101,6 @@ public class WebSocketsParser {
final List<Packet> handshakes = packets.subList(0, httpEnd); final List<Packet> handshakes = packets.subList(0, httpEnd);
parse(wsPackets, handshakes, draft); parse(wsPackets, handshakes, draft);
parsed = true;
} }
private void parse(final List<Packet> wsPackets, final List<Packet> handshakes, Draft_6455 draft) { private void parse(final List<Packet> wsPackets, final List<Packet> handshakes, Draft_6455 draft) {
@@ -136,12 +133,14 @@ public class WebSocketsParser {
.timestamp(lastPacket.getTimestamp()) .timestamp(lastPacket.getTimestamp())
.ttl(lastPacket.getTtl()) .ttl(lastPacket.getTtl())
.ungzipped(lastPacket.isUngzipped()) .ungzipped(lastPacket.isUngzipped())
.webSocketInflated(true) .webSocketParsed(true)
.build() .build()
); );
} }
} }
} }
parsed = true;
} }
public List<Packet> getParsedPackets() { public List<Packet> getParsedPackets() {
@@ -190,11 +189,6 @@ public class WebSocketsParser {
return null; return null;
} }
if (!handshake.contains(WEBSOCKET_EXTENSION_HEADER) &&
!handshake.contains(WEBSOCKET_EXTENSIONS_HEADER)) {
return null;
}
return handshake; return handshake;
} }
@@ -212,10 +206,10 @@ public class WebSocketsParser {
String key = matcher.group(1); String key = matcher.group(1);
matcher = WEBSOCKET_EXTENSIONS_PATTERN.matcher(clientHandshake); matcher = WEBSOCKET_EXTENSIONS_PATTERN.matcher(clientHandshake);
if (!matcher.find()) { String extensions = null;
return null; if (matcher.find()) {
extensions = matcher.group(1);
} }
String extensions = matcher.group(1);
HandshakeImpl1Client clientHandshakeImpl = new HandshakeImpl1Client(); HandshakeImpl1Client clientHandshakeImpl = new HandshakeImpl1Client();
@@ -223,7 +217,10 @@ public class WebSocketsParser {
clientHandshakeImpl.put("Connection", "Upgrade"); clientHandshakeImpl.put("Connection", "Upgrade");
clientHandshakeImpl.put("Sec-WebSocket-Version", version); clientHandshakeImpl.put("Sec-WebSocket-Version", version);
clientHandshakeImpl.put("Sec-WebSocket-Key", key); clientHandshakeImpl.put("Sec-WebSocket-Key", key);
if(extensions != null) {
clientHandshakeImpl.put("Sec-WebSocket-Extensions", extensions); clientHandshakeImpl.put("Sec-WebSocket-Extensions", extensions);
}
return clientHandshakeImpl; return clientHandshakeImpl;
} }
@@ -236,10 +233,10 @@ public class WebSocketsParser {
String accept = matcher.group(1); String accept = matcher.group(1);
matcher = WEBSOCKET_EXTENSIONS_PATTERN.matcher(serverHandshake); matcher = WEBSOCKET_EXTENSIONS_PATTERN.matcher(serverHandshake);
if (!matcher.find()) { String extensions = null;
return null; if (matcher.find()) {
extensions = matcher.group(1);
} }
String extensions = matcher.group(1);
HandshakeImpl1Server serverHandshakeImpl = new HandshakeImpl1Server(); HandshakeImpl1Server serverHandshakeImpl = new HandshakeImpl1Server();